-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement fully automated end-to-end CI testing workflow #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiiwang01
changed the title
WIP - DO NOT MERGE
Implement fully automated end-to-end CI testing workflow
Jun 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a big big fan of the "test-mode" config parameter just for the E2E tests, but to be honest couldn't think about an good alternative for now
amandahla
reviewed
Jun 19, 2023
amandahla
reviewed
Jun 19, 2023
jdkandersson
previously approved these changes
Jun 20, 2023
Closed
yhaliaw
previously approved these changes
Jun 21, 2023
Test coverage for ccd3aff
Static code analysis report
|
jdkandersson
approved these changes
Jun 21, 2023
yhaliaw
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the
github-runner
charm to include a new 'test mode'. This functionality facilitates the charm's deployment on an LXD container cloud, using LXD nesting. Building upon this 'test mode', we have also developed a new e2e test that is fully automated, and operable on GitHub hosted runners. This also resolves the bootstrap problem that we had encountered with our previous e2e test configuration, which requires a self-hosted runner to test self-hosted runner.